Skip to content

Remove mkdirp #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove mkdirp #29

wants to merge 1 commit into from

Conversation

@jakebailey
Copy link
Owner

@jakebailey jakebailey commented Oct 3, 2022 •
edited
Loading

If our build scripts target Node 10+, we can use the builtin mkdir
function in recursive mode instead.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp (this PR)
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from e9316dd to 1c70182 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from ce3b98c to 1d92ee1 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 1c70182 to 25cb26a Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Convert __require back to require for external bundlers Add ts to globalThis for convenience during debugging Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 1d92ee1 to e5d5826 Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 25cb26a to 96f3991 Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Add ts to globalThis for convenience during debugging Remove ref files from testRunner Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from e5d5826 to cdac21e Compare October 4, 2022 19:06
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 96f3991 to 9576473 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from cdac21e to 1ecfbcf Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 9576473 to 4849168 Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Remove ref files from testRunner Restore self-compilation using built compiler in CI tests Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 1ecfbcf to a038a66 Compare October 4, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 4849168 to 12bafe1 Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from a038a66 to a764e7e Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 12bafe1 to 7094ca0 Compare October 6, 2022 18:36
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Temporarily disable template literals Oct 6, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from a764e7e to 28ddc46 Compare October 6, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 7094ca0 to 2349bc4 Compare October 7, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 28ddc46 to c71f45d Compare October 7, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch 2 times, most recently from f5ed806 to fca9261 Compare October 7, 2022 19:31
@jakebailey jakebailey changed the title Temporarily disable template literals Add a --bundle=false variant to CI Oct 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from c71f45d to a2e8cb7 Compare October 7, 2022 19:31
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from fca9261 to 83dcbc3 Compare October 7, 2022 19:36
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from a2e8cb7 to 7b1db7c Compare October 7, 2022 19:36
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 83dcbc3 to 70f88a7 Compare October 7, 2022 22:05
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 7b1db7c to ff36738 Compare October 7, 2022 22:05
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 70f88a7 to 16ff6b8 Compare October 9, 2022 00:42
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from ff36738 to 61928b0 Compare October 9, 2022 00:42
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 4a88477 to fa324cf Compare October 24, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from e4ef938 to 6276686 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from fa324cf to 42b025a Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 6276686 to fe66643 Compare October 27, 2022 04:27
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 42b025a to 31f678e Compare October 27, 2022 04:27
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from fe66643 to 8a4e51a Compare October 27, 2022 17:45
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 31f678e to 0b39e4c Compare October 27, 2022 17:45
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 8a4e51a to 2f79f18 Compare October 28, 2022 02:27
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 0b39e4c to a7e9ea1 Compare October 28, 2022 02:27
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 2f79f18 to 7cc1ad4 Compare October 31, 2022 21:38
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from a7e9ea1 to f85c56f Compare October 31, 2022 21:38
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 7cc1ad4 to 0eba132 Compare November 2, 2022 00:48
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from f85c56f to 8365adc Compare November 2, 2022 00:48
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 0eba132 to 5c8524a Compare November 2, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 8365adc to a3a8116 Compare November 2, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 5c8524a to 9297909 Compare November 2, 2022 19:50
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from a3a8116 to ccedf5c Compare November 2, 2022 19:50
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 9297909 to 3efc360 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from ccedf5c to c735079 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 3efc360 to 92c84be Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from c735079 to d858137 Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 92c84be to 14b7504 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from d858137 to 4df0c02 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 14b7504 to 552c800 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 4df0c02 to 4a0be1d Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-26 branch from 552c800 to 14e5186 Compare November 7, 2022 21:38
@jakebailey
Remove mkdirp
37d74bb 
If our build scripts target Node 10+, we can use the builtin mkdir
function in recursive mode instead.
@jakebailey jakebailey force-pushed the transform-stack-commit-27 branch from 4a0be1d to 37d74bb Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-27 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakebailey